øAslickproductions.org/forum/index.php?PHPSESSID=5f0fck550j2m4m2fpbtkj2vkm1&action=printpage;topic=2050.0e:/My Web Sites/Slick Productions - FFIV Message Board/slickproductions.org/forum/index152a.htmlslickproductions.org/forum/index.php?PHPSESSID=5f0fck550j2m4m2fpbtkj2vkm1&topic=2050.0e:/My Web Sites/Slick Productions - FFIV Message Board/slickproductions.org/forum/index152a.html.zxý1h^ÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÈ`Áo*OKtext/htmlISO-8859-1gzip@øÕo*ÿÿÿÿÿÿÿÿWed, 11 Mar 2020 00:50:30 GMT0ó°° ®0®P®€§²ð®ý1h^{ o* Print Page - New patch: Imp's Retort Bug fix

Board of Slick

Banon's Donkey Farm => Game Modification Station => Topic started by: 13375K31C43R on May 11, 2015, 09:55:07 PM

Title: New patch: Imp's Retort Bug fix
Post by: 13375K31C43R on May 11, 2015, 09:55:07 PM
Hi! Wow, this is my fourth patch today! I've been keeping busy!

So, anyway, this patch fixes the second half of the Psycho Cyan Bug, the first half having already been addressed by Terii Senshi's patch. That patch, although sufficient to limit Cyan's caffeine intake, only fixes one, but not both, of the two bugs that combine to create the Psycho Cyan Bug. The bug Terii Senshi's patch overlooks prevents Cyan's Retort from being cleared if he tries to Retort while he is an Imp, thus allowing him to counterattack every attack against him until his next command input. This patch corrects that.

EDIT: Anyone who has applied Assassin's "Jump Megafix" patch will need to re-download this patch; as the replies explain, the old version causes a problem with the Jump Megafix. If you've previously applied my Zombie/Tapir patch, you'll need to re-download that, too.

EDIT 2: I've now included a patch for the Japanese version of the ROM.

EDIT 3: As of May 3, 2016, this patch no longer uses any free space.

EDIT 4: The new version causes a logical conflict with "Jump Megafix" which causes Jump to never deal any damage. I've now included compatibility patches to circumvent this problem.

EDIT 5: Found a pointer that needed updating and...updated it. It's the pointer to Umaro's "normal attack" procedure. Better download the new version or else your game will reset whenever Umaro attacks.

EDIT 6: GBA port added!
Title: Re: New patch: Imp's Retort Bug fix
Post by: assassin on May 12, 2015, 02:48:39 AM
i believe this will cause an issue when combined with my Jump Megafix, which branches to C2/1633.  the likely problem is having an ally summon Palidor after Cyan/Gogo uses Retort (part 1) will cancel his retort when Cyan/Gogo lands.  a "CMP #$16 / BEQ skip_retort_clear (so F0 06)" at the beginning of your new code could work.  alternatively, moving the "JMP $6752" (plus a NOP) to C2/162F, and having your extra code end with RTS, would be 2 bytes smaller (not needing the command check, so 11 bytes free space vs. 13).

so not a physical patch conflict, but a logical one.

if you're not up to making your 34th .IPS file in two days, then this post will just stand here as a warning and guide for anyone who seeks to combine the two patches.  also, i hope to increase awareness of the Ides of March, and bolster the general public's traffic safety.
Title: Re: New patch: Imp's Retort Bug fix
Post by: 13375K31C43R on May 12, 2015, 03:06:11 AM
Quote
a "CMP #$16 / BEQ skip_retort_clear (so F0 06)" at the beginning of your new code could work.

Even better, I can use a BNE instead, since the command ID for Fight is 0.

Quote
alternatively, moving the "JMP $6752" (plus a NOP) to C2/162F, and having your extra code end with RTS, would be 2 bytes smaller (not needing the command check, so 11 bytes free space vs. 13).

Doesn't that mean overwriting the code already at C2/162F? That clears the "No Critical" and "Ignore True Knight" bits. I'd prefer to leave them alone.
Title: Re: New patch: Imp's Retort Bug fix
Post by: 13375K31C43R on May 12, 2015, 03:12:57 AM
Oh, never mind, I see. I would move those bytes into the free space. Sure, that would work too, and it would probably save some time in the case you mentioned.
Title: Re: New patch: Imp's Retort Bug fix
Post by: assassin on May 12, 2015, 03:15:55 AM
- ah, that should work.
- yep; now you've got it. :)

i'm on the fence with them being the same size now.
Title: Re: New patch: Imp's Retort Bug fix
Post by: 13375K31C43R on May 03, 2016, 11:07:40 PM
:bump: New version.
Title: Re: New patch: Imp's Retort Bug fix
Post by: Xenovant on May 06, 2016, 02:58:13 PM
Any change to the functionality of the patch? I'd prefer to stick with the version that uses free space (less modified code).
Title: Re: New patch: Imp's Retort Bug fix
Post by: 13375K31C43R on May 06, 2016, 05:49:20 PM
Not that I know of, but I needed to clear up the free space to make room for Morph Mayhem, which now uses most of that same free space.
Title: Re: New patch: Imp's Retort Bug fix
Post by: Xenovant on May 06, 2016, 06:19:29 PM
Ah, ok, thanks. If it's just that, making room for another patch, I'll keep using the old version.
Title: Re: New patch: Imp's Retort Bug fix
Post by: 13375K31C43R on September 04, 2016, 03:42:33 PM
:bump: Another update that is important for anyone with Assassin's "Jump Megafix" patch applied.
Title: Re: New patch: Imp's Retort Bug fix
Post by: 13375K31C43R on November 21, 2016, 06:11:26 PM
:bump: New version. Urgent!
Title: Re: New patch: Imp's Retort Bug fix
Post by: C. V. Reynolds on November 22, 2016, 07:15:00 AM
Hoi.

I notice the regular patches in this update are changed, but the ones that are for compatibility with Jump Megafix are not. They are the same as before. Is this intended? Do the Jump Megafix compatible versions lack the error you fixed?

:3
Title: Re: New patch: Imp's Retort Bug fix
Post by: 13375K31C43R on November 22, 2016, 09:23:42 AM
The Jump Megafix-compatible patches aren't standalone patches. All they do is adjust one JMP that needs adjusting because of the changes made by the main patch. They're meant to be applied alongside the main patch, after Jump Megafix has been applied.
Title: Re: New patch: Imp's Retort Bug fix
Post by: C. V. Reynolds on November 22, 2016, 05:37:59 PM
Ohhh... Understood. Now, anyway. I'll need to update the omni-patch again. :eek: Thank you.
Title: Re: New patch: Imp's Retort Bug fix
Post by: 13375K31C43R on February 20, 2018, 11:03:33 PM
:bump: GBA port!