øAslickproductions.org/forum/index.php?PHPSESSID=5f0fck550j2m4m2fpbtkj2vkm1&topic=2042.0e:/My Web Sites/Slick Productions - FFIV Message Board/slickproductions.org/forum/index2a9f.htmlslickproductions.org/forum/index.php?PHPSESSID=5f0fck550j2m4m2fpbtkj2vkm1&board=8.140e:/My Web Sites/Slick Productions - FFIV Message Board/slickproductions.org/forum/index2a9f.html.zx¿%h^ÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÈЋ�8¡OKtext/htmlISO-8859-1gzip8:Ö8¡ÿÿÿÿÿÿÿÿTue, 10 Mar 2020 23:58:16 GMT0ó°° ®0®P®€§²ð®¿%h^&8¡ New patch: Stone Zombie Bug fix

Author Topic: New patch: Stone Zombie Bug fix  (Read 1335 times)

13375K31C43R

  • Ultros
  • *
  • Posts: 675
  • Gender: Male
    • View Profile
    • Leet Sketcher's Final Fantasy III Patches
New patch: Stone Zombie Bug fix
« on: May 06, 2015, 08:31:28 PM »
Hi again! This is the second of my recent patches, which fixes a bug that occurs when a Revivify is used in battle on a Zombified character that is also Petrified. The character in question will no longer be Zombified, but will still have 0 HP. This patch allows the character to gain HP when Zombie status is removed, even if they are still Petrified. This method was chosen because the resulting behaviour matches what would happen if the Revivify was used in these circumstances in the Main Menu.

EDIT: As of May 13, 2015, the attached archives no longer contain the actual fix patches, only the reverse patches. As the replies explain, the fix patches conflicted with Assassin's "If the Force Overrunneth" patch. An updated version of these patches has since been posted that has no reported conflicts with any other patch. Anyone who downloaded this version of the patch should download and apply the reverse patch, then apply the new version. If you had applied "If the Force Overrunneth", reapply it after reversing this patch.
« Last Edit: May 13, 2015, 04:26:06 PM by 13375K31C43R »
"Do not meddle in the affairs of wizards, for they are subtle and quick to anger." -Gildor from The Lord of the Rings

assassin

  • Bane of Retards
  • *
  • Posts: 1,033
  • space bears are not gentle!
    • View Profile
    • My Barren Webpage
Re: New patch: Stone Zombie Bug fix
« Reply #1 on: May 07, 2015, 01:51:33 PM »
nice work again.

- why is FF3-StoneZombie-N.ips so much bigger than the other files?

- your patch won't catch a hypothetical case where Zombie status is removed by Toggling it.  however, for that to be an issue, the attack would be (momentarily) healing HP even when inflicting Zombie, so it's unlikely a hacker would make such a thing.  anyway, to catch that nuance, change the first 6 instructions at C2/65FC to:
Code: [Select]
LDA $3DFC,Y
BIT #$02
BEQ new_6614

man, if "BIT $3DFC,Y" were a valid instruction, i could really shrink the hell out of things. :/

-
Quote from: Readme
Save Point Glitch.txt:

pasting oops.

- my "If the Force Overrunneth" patch uses C2/65FC thru C2/660A.  though it's not a bugfix (as it's only of use for a hacked weapon), so less people would use it.

your best bet is to download every patch, put them in the same directory as yours, and use the great Patch Conflict Finder:

http://web.archive.org/web/20141227210629/http://zephyr129.brinkster.net/patchconflict.html

assassin

  • Bane of Retards
  • *
  • Posts: 1,033
  • space bears are not gentle!
    • View Profile
    • My Barren Webpage
Re: New patch: Stone Zombie Bug fix
« Reply #2 on: May 07, 2015, 05:02:12 PM »
Code: [Select]
LDA $3DFC,Y
LSR
LSR
LDA $3EE4,Y
BIT #$02
BEQ exit
BCC exit
AND #$BF
exit:
RTS

that said, maybe there is an advantage to explicitly checking for "Removes Zombie" in the attack stats.

and as i acknowledged in the prior message, dealing with a hypothetical case isn't exactly urgent.

13375K31C43R

  • Ultros
  • *
  • Posts: 675
  • Gender: Male
    • View Profile
    • Leet Sketcher's Final Fantasy III Patches
Re: New patch: Stone Zombie Bug fix
« Reply #3 on: May 07, 2015, 07:31:29 PM »
Quote
that said, maybe there is an advantage to explicitly checking for "Removes Zombie" in the attack stats.

and as i acknowledged in the prior message, dealing with a hypothetical case isn't exactly urgent.

Yeah, evidently you read the documentation, so you'd know that what the function does (exactly) is:
1. check if we're removing a status (obviously)
2. check if that status is Zombie (obviously)
3. check if Zombie status is there to be removed (because Revivify will still heal you otherwise)

Because this (at least at the time) was the only case I knew of where a status could be removed improperly. The only case I see where the Zombie status can be toggled is with Rippler, which I won't worry about because it's a bug anyway and there's already a patch for it.

Quote
your best bet is to download every patch, put them in the same directory as yours, and use the great Patch Conflict Finder:

I'm not entirely sure about doing that. I'm positive it will work...if I can find all the same patches that affect the free space in bank C2. I know that none of Novalia Spirit's patches are accessible anymore because his site's been archived, so if I find that any of them affect that free space, I'm sort of out of luck. The reason I chose C2/65FC specifically is because, despite that document listing 110 contiguous bytes of free space, that address in my ROM happened to be the location of a free space gap that was EXACTLY the length I needed.
"Do not meddle in the affairs of wizards, for they are subtle and quick to anger." -Gildor from The Lord of the Rings

assassin

  • Bane of Retards
  • *
  • Posts: 1,033
  • space bears are not gentle!
    • View Profile
    • My Barren Webpage
Re: New patch: Stone Zombie Bug fix
« Reply #4 on: May 07, 2015, 10:14:09 PM »
to be sure, since i never commented anything:

Code: [Select]
LDA $3DFC,Y  (get Statuses to Remove, Byte 1 [after accounting for toggles and special effects, and excluding unpossessed statuses])
BIT #$02     (is Zombie among them?)
BEQ label    (branch if not)

so you could technically make this the sole check of your extra function (but with the LSRs seen in my last post to save space).

-------

Quote
The only case I see where the Zombie status can be toggled is with Rippler, which I won't worry about because it's a bug anyway and there's already a patch for it.

Rippler swapping Zombie is not a bug, as that status is in the spell data.  however, it doing so allows for the "Zombie/Rippler" variant of the "Attain a living 0 HP character" bug.  see http://masterzed.cavesofnarshe.com/GameDocs/ff3bug.txt

now, my proposed change wouldn't accomplish anything here, because Rippler has no healing.

-------

according to Novalia's website:
http://web.archive.org/web/20140814054950/http://novaliaspirit.99k.org/ff6/patches.html

"Any patch labelled as a bug fix is optimized in a manner such that no free space has been consumed."
« Last Edit: May 07, 2015, 10:22:56 PM by assassin »

13375K31C43R

  • Ultros
  • *
  • Posts: 675
  • Gender: Male
    • View Profile
    • Leet Sketcher's Final Fantasy III Patches
Re: New patch: Stone Zombie Bug fix
« Reply #5 on: May 08, 2015, 01:34:26 AM »
OK, thanks for the info, I'll update this patch as soon as possible.
"Do not meddle in the affairs of wizards, for they are subtle and quick to anger." -Gildor from The Lord of the Rings