øA slickproductions.org /forum/index.php?PHPSESSID=5f0fck550j2m4m2fpbtkj2vkm1&action=printpage;topic=795.0 e:/My Web Sites/Slick Productions - FFIV Message Board/slickproductions.org/forum/index5266.html delayed slickproductions.org /forum/index.php?PHPSESSID=5f0fck550j2m4m2fpbtkj2vkm1&topic=795.0 e:/My Web Sites/Slick Productions - FFIV Message Board/slickproductions.org/forum/index5266.html.z x |‡g^ ÿÿÿÿ ÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÈ 0°j à OK text/html ISO-8859-1 gzip @øÕ à ÿÿÿÿÿÿÿÿ ÑH Tue, 10 Mar 2020 12:42:59 GMT 0ó° ° ® 0® P® €§² ð® {‡g^ ÿÿÿÿÿÿÿÿ & à
Print Page - Learned spells not being added to list
Board of Slick
Library of the Ancients => Final Fantasy IV Research & Development => Topic started by: Phoenix on September 07, 2008, 06:52:22 PM
Title: Learned spells not being added to list
Post by: Phoenix on September 07, 2008, 06:52:22 PM
I was just testing out the spell learning for my hack, and I noticed that spells outside the White spells won't be learned when adding to a White spell list. I assume the same goes for the other types of lists. JCE, I know you changed some of the spell learning for your hack. Did you run into this? Does anyone know a way around it?
Title: Re: Learned spells not being added to list
Post by: Deathlike2 on September 07, 2008, 07:00:43 PM
I'd hazard a guess and say that's somewhere in the spell learning code.
Title: Re: Learned spells not being added to list
Post by: Phoenix on September 07, 2008, 07:05:13 PM
Yeah, I'm sure it is -- I'm going back through my documents now to see if I ever found the location of that, but I wondered if anyone else knew the fix.
Title: Re: Learned spells not being added to list
Post by: Phoenix on September 07, 2008, 08:37:18 PM
I found the code -- I had the location of something close to it, and was able to find it without too much problem. I think I've got a fix for it; change the data to 801D at the following locations:
FF2us v1.0: 1F342 FF2us v1.1: 1F357 FF4j: 1F35C
Anyone that's willing please test this out for me and let me know if you run into any problems. I did one or two tests which worked, but that's hardly conclusive. Let me know if you run into problems.
Title: Re: Learned spells not being added to list
Post by: Deathlike2 on September 07, 2008, 08:56:52 PM
Well, there's only 3 spell learning types (though, it is unknown how Summons are handled)...
Do scripted events add a spell via the spell learning method method as well?
It would also be interesting to investigate how the item-monster summons work as well...
Title: Re: Learned spells not being added to list
Post by: Dragonsbrethren on September 07, 2008, 09:07:49 PM
Phoenix, are your offsets headered or unheadered?
Title: Re: Learned spells not being added to list
Post by: Phoenix on September 07, 2008, 11:01:49 PM
Quote
Do scripted events add a spell via the spell learning method method as well?
No, using an event script will add a spell to any list with no problem.
Quote
It would also be interesting to investigate how the item-monster summons work as well...
I haven't come across that piece of code yet, but I'll let you know if I do.
Quote
Phoenix, are your offsets headered or unheadered?
Sorry -- they're all headered.
Title: Re: Learned spells not being added to list
Post by: Dragonsbrethren on September 07, 2008, 11:37:49 PM
I found a pretty big problem with this without even changing the spells learned:
Title: Re: Learned spells not being added to list
Post by: Deathlike2 on September 07, 2008, 11:41:22 PM
It looks like you've disabled/removed that code or something...
The learning code probably says "goto to selected/initial spell slot, add spell , jump to end".
What you did was probably change "jump to end" to "goto next spell slot".
Title: Re: Learned spells not being added to list
Post by: Dragonsbrethren on September 07, 2008, 11:52:06 PM
Yeah, it's adding the white spells to all three lists and the black spells to the last two.
:edit:
By "white spells" I mean spells from the first magic list, not necessarily white magic. Your hack is allowing any type of spell to be added to any list, just with this unintended side effect.
Title: Re: Learned spells not being added to list
Post by: Deathlike2 on September 07, 2008, 11:55:45 PM
Thinking about it, the spells are learned within a section (like the spell animation code).. so you might be looking in the wrong place...
Title: Re: Learned spells not being added to list
Post by: Dragonsbrethren on September 08, 2008, 12:11:59 AM
I should have specified that I meant with the hack. Even if you add it to Rydia's unused summon learning list, which should work, it won't work without the hack.
Phoenix: Spells from the third slot only get added to the third, spells from the second slot are added to the second and third, and spells from the first at added to all three.
Title: Re: Learned spells not being added to list
Post by: Phoenix on September 08, 2008, 09:36:28 AM
Thanks for the info, I'll work on a fix. I did indeed just skip the entire check -- I thought it wasn't necessary, but we can now see why it's in place. I'll work on it and post it when I have time to figure it out.
Title: Re: Learned spells not being added to list
Post by: Phoenix on September 09, 2008, 11:04:20 AM
I believe it I got it working. I could have just adjusted the limits of which spells are added to which list, but the problem was that in my hack I don't have the spells grouped by kind, due to necessary out-of-battle effects. Instead, I think I came up with a rather elegant solution, better than the original one. I changed the coding so that the check now looks at the spell name: if it begins with a white magic sphere it will be added to the top list, if it begins with a gray magic sphere it will be added to the third list, and if it begins with anything else it will be added to the second list. (Coincidentally, this works for the magic in my hack and the original game, which was nice.) So, it should work for white, black, ninja, and call magic. I created three IPS patches (FF2 1.0, FF2 1.1, FF4), which I'll release on RHDN if someone can test them and verify that they work. As usual, they're all headered.
:cookie: for me, for creativity and for remembering to create three patches this time :happy:
Title: Re: Learned spells not being added to list
Post by: Deathlike2 on September 09, 2008, 11:08:25 AM
Sounds good, but does that even account for spell animation?
Title: Re: Learned spells not being added to list
Post by: Dragonsbrethren on September 09, 2008, 11:19:57 AM
Looks like it's working fine now, but you may wish to include a disassembly when you release it for anyone who needs to make changes. If I wanted to use this in my hack I'd have to check my magic names from the menu, rather than the place they were originally, I sacrificed icons on the battle names for longer names. Not to mention I moved the icons to the end of the font to free up more tiles for use in dialogue.
This was a really cool way to fix it, I wouldn't have thought to do this, and it should be fairly easy to expand if anyone wants to have more spell types that get added to one of the lists.
Title: Re: Learned spells not being added to list
Post by: Phoenix on September 09, 2008, 11:22:00 AM
Quote
Sounds good, but does that even account for spell animation?
I'm not sure what you mean by spell animation. Do you mean the spell visual effects? Or its battle effects? Either way, the spell effects are unchanged no matter what the spell is named. It's up to the hacker to make sure the name begins with the right colored sphere to add to the correct list. This just gives people the ability to choose which lists spells go to, rather than have it be based on spell number.
Title: Re: Learned spells not being added to list
Post by: Deathlike2 on September 09, 2008, 11:24:30 AM
Sounds good, but does that even account for spell animation?
I'm not sure what you mean by spell animation. Do you mean the spell visual effects? Or its battle effects? Either way, the spell effects are unchanged no matter what the spell is named. It's up to the hacker to make sure the name begins with the right colored sphere to add to the correct list. This just gives people the ability to choose which lists spells go to, rather than have it be based on spell number.
I'm talking about the animation one uses for White, Black, and Summon magic. If for some reason you have a White magic spell in the middle of the monster spell lists, the game will use the Black Magic animation by default.
Title: Re: Learned spells not being added to list
Post by: Phoenix on September 09, 2008, 11:28:19 AM
Looks like it's working fine now, but you may wish to include a disassembly when you release it for anyone who needs to make changes. If I wanted to use this in my hack I'd have to check my magic names from the menu, rather than the place they were originally, I sacrificed icons on the battle names for longer names. Not to mention I moved the icons to the end of the font to free up more tiles for use in dialogue.
I agree -- I was planning on adding the disassembly, since it's not quite contained within the original routine. I had to use some of the extra space at 1F420, which is OK for people who aren't adding routines, but for others (like me) they'll have to move that extra code around to another space. I'll do the write-up for it sometime today and post it to RHDN and here.
Per your situation: I had originally considered a table that looks up which spells should go in which list. I discarded that idea when I thought of my name-based idea, but for your hack that might be the way to go. It shouldn't be too hard to replace the call to the spell names with a call to a table. You can take a look at the routine later at see what you think.
I'm talking about the animation one uses for White, Black, and Summon magic. If for some reason you have a White magic spell in the middle of the monster spell lists, the game will use the Black Magic animation by default.
Yeah, you're right that that's off. That's coded separately, within the spell subroutine. I just ignored that part for my hack, but I'll take a look later and see if I can do the same thing there.
One thing that doesn't work out of the box: any of the spells after 48 (the monster spells) don't really work for normal spell usage because the name data gets out of sync. If somebody could adjust the spell names one way or the other (normal spells to 8 letters or monster spells to 6 letters) then it would be viable.
One more caveat I forgot to mention: you can't add two spells of different lists at the same level. For example, trying to learn Cure and Fire at level 2 will only add Cure. This limitation exists in the original game, and wasn't something I saw an easy work-around for.
Title: Re: Learned spells not being added to list
Post by: Deathlike2 on September 09, 2008, 11:44:18 AM
One more caveat I forgot to mention: you can't add two spells of different lists at the same level. For example, trying to learn Cure and Fire at level 2 will only add Cure. This limitation exists in the original game, and wasn't something I saw an easy work-around for.
I thought Rydia learned them at the same level.. but usually she gains 2 levels while at level 1 and I tend to forget which came first... oh well.
At least the game allows for learning 2 spells of the same list at the same level (Palom does this)...
As an aside, I've often wondered why Tellah and FuSoYa never gained any spells this way.. I guess that could be why. Rydia doesn't learn too many spells to exploit this either...
Title: Re: Learned spells not being added to list
Post by: Dragonsbrethren on September 09, 2008, 11:55:17 AM
One thing that doesn't work out of the box: any of the spells after 48 (the monster spells) don't really work for normal spell usage because the name data gets out of sync. If somebody could adjust the spell names one way or the other (normal spells to 8 letters or monster spells to 6 letters) then it would be viable.
Going with six character names for the enemy skills would be the best option, there's simply no room in the battle magic menu to have longer names than that without completely rearranging the thing. If you start the six character names right where the normal magic leaves off they'll be loaded in the menu fine, then you just need to change the code that prints the spell name in the window during usage:
I thought Rydia learned them at the same level.. but usually she gains 2 levels while at level 1 and I tend to forget which came first... oh well.
Yeah, I thought so too. At first I thought my hack had broken this behavior, but I went back and confirmed it in the original. Not a big deal really, since no characters really needs to learn spells that quickly, which is why I didn't pursue trying to fix it.
Quote from: Dragonsbrethren
Going with six character names for the enemy skills would be the best option, there's simply no room in the battle magic menu to have longer names than that without completely rearranging the thing. If you start the six character names right where the normal magic leaves off they'll be loaded in the menu fine, then you just need to change the code that prints the spell name in the window during usage:
I'm fine with the behavior as is, but I'll take a look at the code you posted later and see what to change. Or is the code you posted already changed?
Title: Re: Learned spells not being added to list
Post by: Dragonsbrethren on September 09, 2008, 12:04:18 PM
2v1.02v1.1 4jHex DataASM Interpretation ----------------------------------------- 1F3341F3491F34EBD 60 15Load A with 1 byte at $7E:1560+X; \ 1F3371F34C1F351D0 2DBranch to 1F366 if zero flag is clear; | 1F3391F34E1F353B9 1C 29Load A with 1 byte at $7E:291C+Y; | load A with the spell number 1F33C1F3511F35685 B9Store A to $00:D+$B9; | 1F33E1F3531F358C9 FFCompare A with #FF; | 1F3401F3551F35AF0 2DBranch to 1F36F if zero flag is set; / 1F3421F3571F35C20 20 F2Jump to subroutine at 1F420; load A with first letter of spell name 1F3451F35A1F35FC9 40Compare A with #40; if A isn't 40 (i.e. white magic), 1F3471F35C1F361D0 06Branch to 1F34F if zero flag is clear; branch to next check 1F3491F35E1F363A5 B3Load A with 1 byte at $00:D+$B3; else if A is 40 and the spell list isn't 0, 1F34B1F3601F365D0 19Branch to 1F366 if zero flag is clear; skip past adding the spell 1F34D1F3621F36780 11Branch to 1F360; otherwise add the spell to the first list 1F34F1F3641F369C9 41Compare A with #41; if A isn't 41 (i.e. call magic), 1F3511F3661F36BD0 08Branch to 1F35B if zero flag is clear; branch to next check 1F3531F3681F36DA5 B3Load A with 1 byte at $00:D+$B3; else if A is 41 1F3551F36A1F36FC9 02Compare A with #02; and the spell list isn't 2, 1F3571F36C1F371D0 0DBranch to 1F366 if zero flag is clear; skip past adding the spell 1F3591F36E1F37380 05Branch to 1F360; otherwise add the spell to the third list 1F35B1F3701F375A5 B3Load A with 1 byte at $00:D+$B3; if A is anything else 1F35D1F3721F3773ADecrement A; and the spell list isn't 1, 1F35E1F3731F378D0 06Branch to 1F366 if zero flag is clear; skip past adding the spell 1F3601F3751F37AA5 B9Load A with 1 byte at $00:D+$B9; \ 1F3621F3771F37C9D 60 15Store A to $7E:1560+X; | 1F3651F37A1F37FC8Increment Y; | 1F3661F37B1F380E8Increment X; | otherwise, add the spell to the 1F3671F37C1F381E6 B7Increment 1 byte at $00:D+$B7; | list and repeat if necessary 1F3691F37E1F383A5 B7Load A with 1 byte at $00:D+$B7; | 1F36B1F3801F385C9 18Compare A with #18; | 1F36D1F3821F387D0 C5Branch to 1F334 if zero flag is clear; / 1F36F1F3841F38960Return from subroutine; return
1F420DAPush X (2 bytes) onto stack; \ 1F42185 DFStore A to $00:D+$DF; | 1F423A9 06Load A with #06; | 1F42585 E1Store A to $00:D+$E1; | loads A with the first letter 1F42720 E0 83Jump to subroutine at 185E0; | of the spell name (40 for 1F42AA6 E3Load X with 2 bytes at $00:D+$E3; | white magic, 41 for call magic) 1F42CBF 00 89 0FLoad A with 1 byte at 78B00+X; | 1F430FAPull 2 bytes from stack and store in X; | 1F43160Return from subroutine; /
Title: Re: Learned spells not being added to list
Post by: Dragonsbrethren on September 09, 2008, 11:49:36 PM
Approved it, along with your edits. Thanks for the disassembly, if I decide to mix up the magic in my hack it looks like it'll be very easy to adapt it to my changes.
Title: Re: Learned spells not being added to list
Post by: Phoenix on September 10, 2008, 12:00:07 AM
Glad to be of help.
Thanks for the code on enemy magic length. I think the only change needed is at 14D9C (headered v1.0), changing it to the first spell number you want to use with 8-letter spells. This will actually help out for my hack, because I was using the first 5 spells of the enemy magic and had to work around the name problem.
Title: Re: Learned spells not being added to list
Post by: DarknessSavior on September 12, 2008, 10:19:05 AM
One thing that doesn't work out of the box: any of the spells after 48 (the monster spells) don't really work for normal spell usage because the name data gets out of sync. If somebody could adjust the spell names one way or the other (normal spells to 8 letters or monster spells to 6 letters) then it would be viable.
Going with six character names for the enemy skills would be the best option, there's simply no room in the battle magic menu to have longer names than that without completely rearranging the thing. If you start the six character names right where the normal magic leaves off they'll be loaded in the menu fine, then you just need to change the code that prints the spell name in the window during usage:
$02/CBAB A6 2A LDX $2A [$00:002A] A:001C X:0004 Y:6400 P:envMxdizc $02/CBAD 7B TDC A:001C X:00E0 Y:6400 P:envMxdizc $02/CBAE A8 TAY A:0000 X:00E0 Y:6400 P:envMxdiZc $02/CBAF BF B0 8A 0F LDA $0F8AB0,x[$0F:8B90] A:0000 X:00E0 Y:0000 P:envMxdiZc $02/CBB3 99 FD 74 STA $74FD,y[$7E:74FD] A:0051 X:00E0 Y:0000 P:envMxdizc $02/CBB6 C8 INY A:0051 X:00E0 Y:0000 P:envMxdizc $02/CBB7 E8 INX A:0051 X:00E0 Y:0001 P:envMxdizc $02/CBB8 C0 08 00 CPY #$0008 A:0051 X:00E1 Y:0001 P:envMxdizc $02/CBBB D0 F2 BNE $F2 [$CBAF] A:0051 X:00E1 Y:0001 P:eNvMxdizc $02/CBBD 7B TDC A:00FF X:00E8 Y:0008 P:envMxdiZC $02/CBBE 99 FD 74 STA $74FD,y[$7E:7505] A:0000 X:00E8 Y:0008 P:envMxdiZC $02/CBC1 4C A0 BC JMP $BCA0 [$7E:BCA0] A:0000 X:00E8 Y:0008 P:envMxdiZC $02/BCA0 AD C0 6C LDA $6CC0 [$7E:6CC0] A:0000 X:00E8 Y:0008 P:envMxdiZC $02/BCA3 F0 03 BEQ $03 [$BCA8] A:0000 X:00E8 Y:0008 P:envMxdiZC $02/BCA8 4C 60 93 JMP $9360 [$7E:9360] A:0000 X:00E8 Y:0008 P:envMxdiZC $02/9360 20 CA 92 JSR $92CA [$02:92CA] A:0000 X:00E8 Y:0008 P:envMxdiZC I'd just find some empty space large enough to contain the eight character list and change the offset it's looking at, but you could easy load the six character names here too.
*buzzer*
I've got eight character spells (that includes the magic-type icon), and I didn't rearrange a thing:
(http://dsrh.charsisforge.org/ffivmagic.png)
All you have to do is change the fixed length load from $06 to $08, move the list to some empty space in the ROM, and change the assembly to reflect those changes.
~DS
Title: Re: Learned spells not being added to list
Post by: Dragonsbrethren on September 12, 2008, 04:14:45 PM
Going with six character names for the enemy skills would be the best option, there's simply no room in the battle magic menu to have longer names than that without completely rearranging the thing.
Title: Re: Learned spells not being added to list
Post by: DarknessSavior on September 15, 2008, 07:29:56 AM
Doh. Sorry. >.<
Yeah, I'm gonna have fun with that one when I do it. Though, as of right now, the battle magic menu is still loading from the original list of spells, so it still works as it originally did, just with truncated names.
~DS
Title: Re: Learned spells not being added to list
Post by: Deathlike2 on October 11, 2008, 04:15:44 PM
The only way of expanding the magic menu in battle is to do what the RPGOne's translation does with the spell list.
You would have to remove the MP Cost Box and move the text around to the top (or bottom) of the list... then you can expand the spells freely (it seems to expand to only 7 characters plus spell sprite).
Title: Re: Learned spells not being added to list
Post by: DarknessSavior on October 13, 2008, 07:26:48 AM
You mean j2e's patch? >.>
Eh, 7 characters would be enough. That's how much I've got in the main menu, though that's not enough to get the longest spell names in.
~DS
Title: Re: Learned spells not being added to list
Post by: Deathlike2 on October 13, 2008, 01:18:17 PM
No, I really meant RPGOne's translation patch for FF6.
See how the spell menu looks different? The MP box was removed in favor of expanding the spell names in battle.
Title: Re: Learned spells not being added to list
Post by: Dragonsbrethren on October 13, 2008, 02:44:15 PM
I think using shorter names is better than sacrificing menu aesthetics like RPGOne did though, I know they had planned on fixing all of the expanded menus for the 2.0 patch but some of them ended up really ugly as a result of expansion. That said the expanded battle magic menu isn't too bad, but they would've been better off switching to two columns like FF3us, that's easier said than done though.
Title: Re: Learned spells not being added to list
Post by: Deathlike2 on January 27, 2009, 06:30:11 PM
Something to think about... I'm not sure if this is the right post to :bump:
As you know, you can add monster spells to the list (as least I think with this patch, I assume it's doable now?)
The issue though is that monster spells are not parsed properly through a magic list.. so if you've seen spells with funky names in the spell list (other than the very first spell), that's the parsing issue at work as obviously it wasn't intended for regular spellcasting consumption.
Perhaps a followup patch to fix this behavior in the spell displaying routines (in the menu and in the spell list in battle) would help a lot here. Fortunately, the spell is displayed correctly in battle... which is nice.
Title: Re: Learned spells not being added to list
Post by: Dragonsbrethren on January 28, 2009, 04:33:22 PM
The spell name loading routine just copies six characters, regardless of the length of the name (the enemy skills are eight characters, so it breaks). It's fairly painless to fix, you've just got to move the spell name list somewhere else in the ROM and do six character versions of the enemy skills. What I would do is do the six character names where the spell names are now, then expand your ROM to 12Mb and paste the old list in that space somewhere. Update the offset in this code and everything should work great:
$02/CBAF BF B0 8A 0F LDA $0F8AB0,x[$0F:8B90] A:0000 X:00E0 Y:0000 P:envMxdiZc I don't have the ROM open in front of me, but I'm 90% certain that's the offset of the first eight character spell name, and that the code is from FF2us r1.1.