øAslickproductions.org/forum/index.php?PHPSESSID=5f0fck550j2m4m2fpbtkj2vkm1&topic=2238.0e:/My Web Sites/Slick Productions - FFIV Message Board/slickproductions.org/forum/indexe033-2.htmlslickproductions.org/forum/index.php?PHPSESSID=5f0fck550j2m4m2fpbtkj2vkm1&board=8.80e:/My Web Sites/Slick Productions - FFIV Message Board/slickproductions.org/forum/indexe033-2.html.zx %h^ÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÈ0Pd»OKtext/htmlISO-8859-1gzip8:Ö»ÿÿÿÿÿÿÿÿTue, 10 Mar 2020 23:55:17 GMT0ó°° ®0®P®€§²ð® %h^ÿÿÿÿÿÿÿÿü#» Jump doesn't seem to work...

Author Topic: Jump doesn't seem to work...  (Read 1778 times)

13375K31C43R

  • Ultros
  • *
  • Posts: 675
  • Gender: Male
    • View Profile
    • Leet Sketcher's Final Fantasy III Patches
Jump doesn't seem to work...
« on: June 18, 2016, 12:06:38 PM »
Hi everyone! I've recently discovered a problem in my heavily-patched FF3us ROM, whereby the Jump command has become completely useless. It almost always misses because the hit rate somehow becomes 0 during the landing sequence, and even when it does hit, no damage is dealt and no damage numbers appear. I have a bad feeling that one of my patches is causing this issue, but I don't know which. Any help I can get on this very critical issue would be much appreciated!
"Do not meddle in the affairs of wizards, for they are subtle and quick to anger." -Gildor from The Lord of the Rings

Tenkarider

  • Guard Leader
  • *
  • Posts: 50
    • View Profile
Re: Jump doesn't seem to work...
« Reply #1 on: June 18, 2016, 02:17:11 PM »
how many chances are there that the guilty is "dead in the air" bugfix latest changes?
dunno, maybe something related to death status midair that blocks the damage and for some reason it's applied no matter what?

Imzogelmo

  • Ogopogo Aficianado
  • *
  • Posts: 241
  • Gender: Male
  • Ask me about my other job.
    • View Profile
    • NEPROMR
Re: Jump doesn't seem to work...
« Reply #2 on: June 18, 2016, 05:25:44 PM »
If you can give me a patch of your ROM, I can do some tracing in my spare time.
5/31/16 - I have an assembly of the battle portion of C2, relocated to the F0 bank, which has both vanilla and patch code in my dropbox. I'll be updating it with additional patches as I have time. I will *not* be releasing it publicly, but ask me for the link and I'll share.

Xenovant

  • Tunnel Armor
  • *
  • Posts: 154
  • (ಠ_ಠ)
    • View Profile
Re: Jump doesn't seem to work...
« Reply #3 on: June 18, 2016, 06:31:02 PM »
Could it be that you modified your rom for testing something (a new fix or something like that) and you forgot about it? :P Maybe the dead in the air fix, like tenkarider says.

I have most of your patches applied to my hack and everything seems fine. I have tested the ones I don't have, and no problems either. I haven't tested the event fixes that I don't use, but I doubt one of them is the culprit xD

Imzogelmo

  • Ogopogo Aficianado
  • *
  • Posts: 241
  • Gender: Male
  • Ask me about my other job.
    • View Profile
    • NEPROMR
Re: Jump doesn't seem to work...
« Reply #4 on: June 19, 2016, 12:22:58 AM »
That reminds me, I need to find/make a full event code with fixes and tokenized pointers...  :celosa:
5/31/16 - I have an assembly of the battle portion of C2, relocated to the F0 bank, which has both vanilla and patch code in my dropbox. I'll be updating it with additional patches as I have time. I will *not* be releasing it publicly, but ask me for the link and I'll share.

13375K31C43R

  • Ultros
  • *
  • Posts: 675
  • Gender: Male
    • View Profile
    • Leet Sketcher's Final Fantasy III Patches
Re: Jump doesn't seem to work...
« Reply #5 on: June 19, 2016, 02:34:50 AM »
I'll post my current prototype for the new version of Dead in the Air, if you want to give that a test. This patch should be applied to a clean ROM because so far I've discovered that this patch conflicts with at least seven different patches. Hopefully I can find an easier way to make the space I need, without all these conflicts. I've also included an RTF of code changes.
"Do not meddle in the affairs of wizards, for they are subtle and quick to anger." -Gildor from The Lord of the Rings

Xenovant

  • Tunnel Armor
  • *
  • Posts: 154
  • (ಠ_ಠ)
    • View Profile
Re: Jump doesn't seem to work...
« Reply #6 on: June 19, 2016, 04:54:43 PM »
At first sight, everything is fine on that patch, including the bug(s) you were speaking of. I'll test it deeper tomorrow, and if I see something, I'll post it.

That reminds me, I need to find/make a full event code with fixes and tokenized pointers...  :celosa:

Fixes are always welcome, but if you make the tokens thing now, I'll hate you for not doing it when I needed it :P  :happy:

Imzogelmo

  • Ogopogo Aficianado
  • *
  • Posts: 241
  • Gender: Male
  • Ask me about my other job.
    • View Profile
    • NEPROMR
Re: Jump doesn't seem to work...
« Reply #7 on: June 19, 2016, 07:53:40 PM »
I've done it before, I just have to find that stuff and revamp it. The event code is such a ...thing... that it exists as a sort of hodgepodge. It's full of bugs, but the majority of them are so minor that they hardly get noticed, and the effort to insert and shift the events is so much that it's a major hurdle to overcome for minor fixes. And the old "create a new subroutine and jump to it" method is wasteful when the remaining space is so precious. So yes, a full tokenized system, combined with some serious optimization, is needed to make the development time worth the effort for fixing some minor bugs.

Sorry if it's late, but I can only work on it as my time permits.
5/31/16 - I have an assembly of the battle portion of C2, relocated to the F0 bank, which has both vanilla and patch code in my dropbox. I'll be updating it with additional patches as I have time. I will *not* be releasing it publicly, but ask me for the link and I'll share.

Xenovant

  • Tunnel Armor
  • *
  • Posts: 154
  • (ಠ_ಠ)
    • View Profile
Re: Jump doesn't seem to work...
« Reply #8 on: June 19, 2016, 09:08:19 PM »
Sorry if it's late, but I can only work on it as my time permits.

You make me feel bad, even when I was just joking :P


Imzogelmo

  • Ogopogo Aficianado
  • *
  • Posts: 241
  • Gender: Male
  • Ask me about my other job.
    • View Profile
    • NEPROMR
Re: Jump doesn't seem to work...
« Reply #9 on: June 28, 2016, 11:44:16 PM »
Not trying to make you feel bad. Just pointing out the obvious. :P

I have an idea to put up an assemble-able disassembly for the code banks. Maybe on github or something. Then have some branches where code was optimized, and with patches inserted, etc. I think the free space in C2 is close to exhausted, but there's plenty of stuff that can be optimized and there are large chunks of data that could be moved to free space within traditionally data-only banks...

Of course we've been talking about doing a ROM map redo for a while, but I feel like it will take somebody just throwing something out there for it to really get started. I don't mind being the guinea pig. I've already got 2 of the banks done (i.e. they can assemble identical to vanilla). At the same time I'm trying to do a project with the code (not sure what to call it yet) which has control bytes to turn on or off certain code.

It's getting close to the point that I'll need another set of eyes on it to get it just right. I'm really curious to know how much can be trimmed off those banks. :)
5/31/16 - I have an assembly of the battle portion of C2, relocated to the F0 bank, which has both vanilla and patch code in my dropbox. I'll be updating it with additional patches as I have time. I will *not* be releasing it publicly, but ask me for the link and I'll share.

13375K31C43R

  • Ultros
  • *
  • Posts: 675
  • Gender: Male
    • View Profile
    • Leet Sketcher's Final Fantasy III Patches
Re: Jump doesn't seem to work...
« Reply #10 on: September 02, 2016, 07:51:31 PM »
OK, I apologize that this took so long. I've made a patch that can be applied to a clean, headered ROM in order to get my version that has the flawed Jump command. What took so long was trying to get around the size limits on this forum.

I've read at least one offer to try tracing my Jump problems. For anyone who's willing, here's a link to download my patch.
"Do not meddle in the affairs of wizards, for they are subtle and quick to anger." -Gildor from The Lord of the Rings

Xenovant

  • Tunnel Armor
  • *
  • Posts: 154
  • (ಠ_ಠ)
    • View Profile
Re: Jump doesn't seem to work...
« Reply #11 on: September 03, 2016, 10:45:56 AM »
The game crashes when you enter a combat on a 1.0 headered rom, but it works and I see the problems you were talking about, when I apply it to a headered v1.1 :P  I guess that's the problem, you added changes that were meant for the v1.0 rom to the 1.1 one :tongue:
« Last Edit: September 03, 2016, 10:52:52 AM by Xenovant »

13375K31C43R

  • Ultros
  • *
  • Posts: 675
  • Gender: Male
    • View Profile
    • Leet Sketcher's Final Fantasy III Patches
Re: Jump doesn't seem to work...
« Reply #12 on: September 03, 2016, 10:57:51 AM »
Ah yes, forgot to mention that. :laugh:
"Do not meddle in the affairs of wizards, for they are subtle and quick to anger." -Gildor from The Lord of the Rings

Xenovant

  • Tunnel Armor
  • *
  • Posts: 154
  • (ಠ_ಠ)
    • View Profile
Re: Jump doesn't seem to work...
« Reply #13 on: September 04, 2016, 09:04:48 AM »
Well... I have no idea why that happens...   :sad:

I can say the culprit isn't one of the patches you have released (v1.0 or v1.1), and it isn't the "dead in the air" patch you posted on this thread, either, it has to be something else. I have been debugging your hack, too, but I couldn't find anything, at least for now  >_<'

13375K31C43R

  • Ultros
  • *
  • Posts: 675
  • Gender: Male
    • View Profile
    • Leet Sketcher's Final Fantasy III Patches
Re: Jump doesn't seem to work...
« Reply #14 on: September 04, 2016, 02:49:58 PM »
OK, I managed to fix it! I found the source of the problem: my Imp's Retort patch, the latest version, is not compatible with Assassin's Jump Megafix patch. Jump Megafix jumps to a section of code that is altered by Imp's Retort. I will fix this ASAP.
"Do not meddle in the affairs of wizards, for they are subtle and quick to anger." -Gildor from The Lord of the Rings